Reset Input Toolbar can over calculate from bottomOffset props #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text input tool bar can be rendered incorrectly due to the bottom offset
erenn16
added a commit
to skillz/react-native-gifted-chat
that referenced
this pull request
Feb 24, 2017
|
@erenn16 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue in my implementation where I have a bottom offset for the input tool bar in the chat. When a user inputs a message, dismisses the keyboard and then sends the message, the text input tool bar would end up being rendered too low and behind a few other view components. Instead of using the this.props.bottomOffset, it should be using this.getBottomOffset() so that it doesn't incorrectly position when the keyboard is dismissed. Verified that sending a message with the keyboard showing still works as intended.