Added onAvatarPress #264
Closed
Added onAvatarPress #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
reviewed
Oct 18, 2016
| @@ -118,7 +118,7 @@ See [example/App.js](example/App.js) | |||
| - **`renderSend`** _(Function)_ - render the send button | |||
| - **`renderAccessory`** _(Function)_ - renders a second line of actions below the message composer | |||
| - **`bottomOffset`** _(Integer)_ - distance of the chat from the bottom of the screen, useful if you display a tab bar | |||
|
|
|||
| - **`onAvatarPress`** _(Function)_ - Called when Avatar is presses | |||
There was a problem hiding this comment.
It seems that you have a typo on «presses». It should be «pressed».
dgdavid
approved these changes
Oct 18, 2016
dgdavid
reviewed
Oct 18, 2016
|
+1 |
cooperka
requested changes
Apr 10, 2017
There was a problem hiding this comment.
This is great @SunnyGurnani! Could you please rebase so we can merge it?
| @@ -27,6 +27,7 @@ export default class Avatar extends React.Component { | |||
| <View style={[styles[this.props.position].container, this.props.containerStyle[this.props.position]]}> | |||
| <GiftedAvatar | |||
| avatarStyle={StyleSheet.flatten([styles[this.props.position].image, this.props.imageStyle[this.props.position]])} | |||
| onPress={this.props.onAvatarPress} | |||
There was a problem hiding this comment.
We probably don't want onPress here because this is actually a blank avatar that isn't visible.
|
This PR can be closed in favor of #427 (rebased). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GiftedAvatar already had onPress but was not being utilized. Added onAvatarPress () function.