Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dataset.name with dataset.id #183

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

tomekster
Copy link
Contributor

@tomekster tomekster commented Jan 30, 2024

Description

Replace dataset.name with dataset.id in docs.
(The former throws AttributeError: 'MinariDataset' object has no attribute '_name')

Type of change

Please delete options that are not relevant.

  • Bug fix

Screenshots

N/A

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…r: 'MinariDataset' object has no attribute '_name')
Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@younik younik merged commit e1e68ce into Farama-Foundation:main Jan 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants