test: add spec for fa-flipper child removal

Famous · Aug 2, 2014 · b081f26 · b081f26
1 parent f97e357
commit b081f26
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/dist/famous-angular.js b/dist/famous-angular.js
@@ -1810,6 +1810,7 @@ angular.module('famous.angular')
               $famousDecorator.sequenceWith(
                 scope,
                 function(data) {
+                  //TODO:  support fa-index + sorting children instead of just a stack
                   var _childCount = isolate.children.length;
                   if (_childCount === 0) {
                     isolate.renderNode.setFront(data.renderNode);
@@ -1821,9 +1822,13 @@ angular.module('famous.angular')
 
                   isolate.children.push(data.renderNode);
                 },
-                // TODO: support removing children
                 function(childScopeId) {
-                  throw new Error('unimplemented: fa-flipper does not support removing children');
+                  //TODO:  support fa-index + sorting children and removing
+                  //       the child at the proper index instead of just popping off a stack
+
+                  //Since children should handle hiding themselves, all we need to do is
+                  //update our children array
+                  isolate.children.splice(isolate.children.length - 1, 1);
                 }
               );
             },