fix: remove $timeout in faScrollView and use scope.$$postDigest instead

With a large collection, this is much faster than lots of $timeout calls.
Famous · Jul 7, 2014 · 137f260 · 137f260
1 parent b4477a2
commit 137f260
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 37 deletions.
diff --git a/dist/famous-angular.js b/dist/famous-angular.js
@@ -3366,7 +3366,7 @@ angular.module('famous.angular')
  */
 
 angular.module('famous.angular')
-  .directive('faScrollView', ['$famous', '$famousDecorator', '$timeout', function ($famous, $famousDecorator, $timeout) {
+  .directive('faScrollView', ['$famous', '$famousDecorator', function ($famous, $famousDecorator) {
     return {
       template: '<div></div>',
       restrict: 'E',
@@ -3387,14 +3387,8 @@ angular.module('famous.angular')
             isolate.renderNode = new ScrollView(options);
 
             var updateScrollview = function(init){
-              //$timeout hack used here because the
-              //updateScrollview function will get called
-              //before the $index values get re-bound
-              //through ng-repeat.  The result is that
-              //the items get sorted here, then the indexes
-              //get re-bound, and thus the results are incorrectly
-              //ordered.
-              $timeout(function(){
+              // Synchronize the update on the next digest cycle
+              scope.$$postDigest(function(){
                 _children.sort(function(a, b){
                   return a.index - b.index;
                 });
@@ -3415,9 +3409,8 @@ angular.module('famous.angular')
 
                 var viewSeq = new ViewSequence(options);
                 isolate.renderNode.sequenceFrom(viewSeq);
-
-              })
-            }
+              });
+            };
 
             $famousDecorator.sequenceWith(
               scope,