Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph list trim fix #795

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Paragraph list trim fix #795

merged 3 commits into from
Feb 20, 2019

Conversation

JFormDesigner
Copy link
Contributor

@JFormDesigner JFormDesigner commented Dec 21, 2018 •
edited
Loading

fixes #777 and fixes #788

details are here #777 (comment)

@JFormDesigner JFormDesigner mentioned this pull request Dec 21, 2018
Closed
@Jugen
Copy link
Collaborator

Jugen commented Jan 21, 2019

Hi @JFormDesigner, thanks for this PR and sorry for the delayed response.

I do have some concerns about the validity of changing trim to using reference comparison, so what I've done is applied your changes into my project and am running it in a production environment (as of today) to see how it behaves.

Have you by any chance being using this PR in your project, if not could you also maybe try it ?

@Jugen Jugen merged commit 6d49399 into FXMisc:master Feb 20, 2019
@Jugen Jugen mentioned this pull request Feb 20, 2019
Closed
@JFormDesigner JFormDesigner deleted the paragraph-list-trim-fix branch March 12, 2019 10:22
This was referenced Mar 18, 2020
Closed
Merged
Jugen added a commit that referenced this pull request Mar 23, 2020
@Jugen
Fix scrollbar jump (#918)
aaee089 
* Improved visibleParToAllParIndex, Reverted fix for #795
* Improved method allParToVisibleParIndex
* Added exception trap and test for #788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@JFormDesigner @Jugen @lhttjdr @DevCharly