Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: Update caret position after replace call #473

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Fix regression: Update caret position after replace call #473

merged 4 commits into from
Mar 28, 2017

Conversation

JordanMartinez
Copy link
Contributor

Turns out I didn't copy this code over into the view correctly because it mixed model and view API calls together

@JordanMartinez
Copy link
Contributor Author

Fixes #472

@JordanMartinez JordanMartinez merged commit c7efe0e into FXMisc:master Mar 28, 2017
@JordanMartinez JordanMartinez deleted the fixCaretAdvanceIssue branch March 28, 2017 21:14
@JordanMartinez
Copy link
Contributor Author

This fix also insures a ESD#replace call doesn't occur unless an actual change will occur by it. Otherwise, it would throw an IllegalStateException when trying to construct a TextChange that doesn't insert/delete/replace anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JordanMartinez