Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request follow caret #378

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Request follow caret #378

merged 2 commits into from
Oct 7, 2016

Conversation

JordanMartinez
Copy link
Contributor

Should fix #101, but I'm not sure if I implemented it correctly.

TomasMikula
TomasMikula reviewed Oct 6, 2016
View reviewed changes
richtextfx/src/main/java/org/fxmisc/richtext/StyledTextAreaBehavior.java
@@ -169,13 +169,14 @@
.orElse(otherNavigation).ifConsumed((b, e) -> b.view.clearTargetCaretOffset())
.orElse(verticalNavigation)
.orElse(copyAction)
.orElse(charPressConsumer);
.orElse(charPressConsumer)
.ifConsumed((b, e) -> b.view.requestFollowCaret());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these last two lines should be swapped? Shouldn't make a change in observable behavior, but when charPressConsumer consumes an event, we expect a KEY_TYPED event, and we requestFollowCaret there.

@JordanMartinez
Copy link
Contributor Author

Updated in light of your comment.

@TomasMikula
Copy link
Member

👍

@TomasMikula TomasMikula merged commit 19c4480 into FXMisc:master Oct 7, 2016
@JordanMartinez
Copy link
Contributor Author

Since that's now a public method... we should add some javadoc to explain
its usage in the method and class javadoc

On Oct 6, 2016 5:18 PM, "Tomas Mikula" notifications@github.com wrote:

Merged #378 #378.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#378 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIBfbYQgpR3gDBTSNEd5jABlbgbWXx8sks5qxY_JgaJpZM4KPf8j
.

@TomasMikula TomasMikula mentioned this pull request Oct 7, 2016
Closed
@JordanMartinez JordanMartinez deleted the requestFollowCaret branch October 7, 2016 03:38
@JordanMartinez
Copy link
Contributor Author

I amended the commit, but it seems to have shoved the two commits into one. Thus, requestFollowCaret isn't actually public in this PR. I'll need to open another one to correct that issue.

@JordanMartinez JordanMartinez mentioned this pull request Oct 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasMikula TomasMikula TomasMikula left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StyledTextArea scrolls to the caret every time span style is changed
2 participants
@JordanMartinez @TomasMikula