-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Shift) + Shortcut + Left/Right skips only 1 word boundary, not 2 #370
Conversation
Any comments on this? |
I'm afraid this fix would cause the caret to move like this, i.e. sometimes skipping just the space:
|
.... isn't that kind of the point? If it's something you don't want in RTFX, then that issue should have been closed a long time ago. |
I think this is the desired behavior: When moving to the right:
Analogously when moving to the left. This is different from both the current state and this PR. |
7a5a5ed
to
859bf87
Compare
The new commit should do it. |
Shouldn't this also factoring in tabs? |
I would use isWhitespace. |
…o prev/next word boundary
859bf87
to
2c3bd1b
Compare
How's that? On another hand, it doesn't work if there are multiple blank lines between one word and the next. The caret
Is that desired? |
Well, that is also the current behavior. I think it is a problem of BreakIterator.getWordInstance() that it considers a line break as a word boundary. |
This fixes #200. I could write a test for it, but that would require adding a TestFX test dependency in headless mode so that the travis build still works correctly.