Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixed 216 #240

Closed
wants to merge 6 commits into from
Closed

Commits on Jan 14, 2016

  1. Renamed Paragraph to NormalParagraph so that later commits will be ea…

    …sier to understand when interface `Paragraph<S, PS>` is implemented .
    JordanMartinez committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    9297625 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2016

  1. Partial commit: created Paragraph interface which EmptyParagraph and …

    …NormalParagraph will implement.
    JordanMartinez committed Jan 15, 2016
    Configuration menu
    Copy the full SHA
    70af4c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebe04ac View commit details
    Browse the repository at this point in the history
  3. Partial Commit: Made StyledDoc-related classes switch from NormalPara…

    …graph to Paragraph.
    
    EditableStyledDocument details
    - Constructor now initializes itself with an EmptyParagraph
    - Replace method checks for NormalParagraphs that should be EmptyParagraphs because their length == 0
    - getStyleForInsertionAt(Position) will return `initialStyle` if that boolean property is true or if the Paragraph returned is EmptyParagraph
    
    ReadOnlyStyledDocument details
    - The following were adjusted to account for saving/loading an EmptyParagraph or NormalParagraph:
     - fromString() method
     - Codecs
    JordanMartinez committed Jan 15, 2016
    Configuration menu
    Copy the full SHA
    6d0894a View commit details
    Browse the repository at this point in the history
  4. Final Commit: Made View-related classes (and RichText demo) switch fr…

    …om NormalParagraph to Paragraph
    
    ParagraphText details
    - When ParagraphText is displaying an EmptyParagraph, it will seem like the paragraph and the caret aren't visible. To fix this, an empty TextExt was added. There is probably a better way to make the line and caret appear. Additionally, the caret's height might not appear to be the same elsewhere in the area if the initialStyle used in EditableStyledDocument doesn't specify what the fontsize should be of the text.
    - There's probably now a way to show that a newline char is highlighted when user selects something by `new TextExt(" ")` rather than `new TextExt("")`. For example, when a user selects multiple lines and one of them is an EmptyParagraph, the TextExt could be used to show that that line is selected. As of now, there is no indication of this to the user.
    JordanMartinez committed Jan 15, 2016
    Configuration menu
    Copy the full SHA
    e8f8127 View commit details
    Browse the repository at this point in the history
  5. Moved SubMap and its implementation into EditableStyledDocument s…

    …o that `StyledDocument`s that are used to initialize a new `RichTextChange` don't have any `NormalParagraph` instances in their respective paragraphs when those instances length is 0. Instead, remaps the paragraphs to `EmptyParagraph` objects using `EditableStyledDocument`'s `initialStyle` and `initialParagraphStyle`.
    JordanMartinez committed Jan 15, 2016
    Configuration menu
    Copy the full SHA
    4d86628 View commit details
    Browse the repository at this point in the history