Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dynamic plugin reloading #522

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Disable dynamic plugin reloading #522

merged 1 commit into from
Jan 12, 2024

Conversation

FWDekker
Copy link
Owner

@FWDekker FWDekker commented Jan 12, 2024

Instead of fixing #520, this just disables the dynamic reloading feature.

I spent more than 6 hours trying to find out why dynamic reloading didn't work, found a bunch of supposed memory leaks, and then found extremely insufficient documentation on JetBrains' end on alternative design patterns to avoid those leaks. (Apparently every single Companion object was still referenced by the classloader. How am I supposed to avoid that?)

It's not worth my time. By explicitly disabling dynamic reloading, at least users won't see their IDE trying and failing to dynamically reload the plugin.

@FWDekker FWDekker added the bug Something isn't working label Jan 12, 2024
@FWDekker FWDekker self-assigned this Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4afe529) 85.50% compared to head (ca43a2f) 85.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          51       51           
  Lines        2035     2035           
  Branches      343      343           
=======================================
  Hits         1740     1740           
  Misses        224      224           
  Partials       71       71           

@FWDekker FWDekker merged commit 2274a0e into main Jan 12, 2024
8 checks passed
@FWDekker FWDekker deleted the dynamic-loading branch January 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant