Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve EAP IDEs for plugin verifier #329

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

FWDekker
Copy link
Owner

@FWDekker FWDekker commented Jun 5, 2020

Fixes #328.

@PawelLipski, can you confirm that this resolves the issue for you?

@FWDekker FWDekker added the bug Something isn't working label Jun 5, 2020
@FWDekker FWDekker self-assigned this Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #329   +/-   ##
=========================================
  Coverage     78.99%   78.99%           
  Complexity      183      183           
=========================================
  Files            39       39           
  Lines          1338     1338           
  Branches        158      158           
=========================================
  Hits           1057     1057           
  Misses          258      258           
  Partials         23       23           

@PawelLipski
Copy link

Wow, that's a quick response even for commercial standards, let alone in open source :D Thanks!

I verified my plugin against IC-202-EAP-SNAPSHOT using the updated script, everything went as expected.

@FWDekker
Copy link
Owner Author

FWDekker commented Jun 5, 2020

No problem! It's just a matter of procrastinating on more important things ;-)

@FWDekker FWDekker merged commit 754ad6d into master Jun 5, 2020
@FWDekker FWDekker deleted the verifier-snapshots branch June 5, 2020 11:00
@PawelLipski
Copy link

PawelLipski commented Jun 5, 2020

@ up: haha the longer I live, the more I'm convinced such controlled procrastination is the sole sustainable way to provide motivation for basically anything that requires effort ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identifierToDependency doesn't handle EAP releases properly
2 participants