Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No integer inserted at exactly maximum range size #370

Closed
FWDekker opened this issue Mar 23, 2021 · 0 comments · Fixed by #371
Closed

No integer inserted at exactly maximum range size #370

FWDekker opened this issue Mar 23, 2021 · 0 comments · Fixed by #371
Assignees
@FWDekker
Labels
bug Something isn't working

Comments

@FWDekker
Copy link
Owner

As reported by @solonovamax, setting the integer range from 0 to 9,223,372,036,854,775,807 results in no errors when saving the settings, but also fails to generate any data (or exceptions) in the preview or in the editor.

Sounds an awful lot like an off-by-one error.
@FWDekker FWDekker added the bug Something isn't working label Mar 23, 2021
@FWDekker FWDekker self-assigned this Mar 23, 2021
@FWDekker FWDekker changed the title Nothing happens with No integer inserted at exactly maximum range size Mar 23, 2021
FWDekker added a commit that referenced this issue Mar 23, 2021
@FWDekker
Add randomLong function to prevent overflows
953c743 
Removes the need for a maximum value range in integer settings.

Fixes #367 and fixes #370.
@FWDekker FWDekker mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FWDekker FWDekker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add randomLong function to prevent overflows FWDekker/intellij-randomness
1 participant
@FWDekker