Support all WaveBank versions #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/FACT_internal.c
Outdated
| @@ -3105,7 +3107,15 @@ uint32_t FACT_INTERNAL_ParseWaveBank( | |||
| #define DOSWAP_64(x) x = FAudio_swap64BE(x) | |||
|
|
|||
| fileOffset = offset; | |||
| READ(&header, sizeof(header)) | |||
|
|
|||
| memset(&header, 0, sizeof(header)); | |||
There was a problem hiding this comment.
Suggested change
| memset(&header, 0, sizeof(header)); | |
| FAudio_zero(&header, sizeof(header)); |
src/FACT_internal.c
Outdated
Comment on lines
3114
to
3116
| if (header.dwVersion > FACT_CONTENT_VERSION_2_4) | ||
| READ(&header.dwHeaderVersion, sizeof(header.dwHeaderVersion)); |
There was a problem hiding this comment.
Suggested change
| if (header.dwVersion > FACT_CONTENT_VERSION_2_4) | |
| READ(&header.dwHeaderVersion, sizeof(header.dwHeaderVersion)); | |
| if (header.dwVersion > FACT_CONTENT_VERSION_2_4) | |
| { | |
| READ(&header.dwHeaderVersion, sizeof(header.dwHeaderVersion)); | |
| } |
src/FACT_internal.c
Outdated
| } | ||
| */ | ||
| if ( header.dwVersion < FACT_CONTENT_VERSION_2_4 || | ||
| header.dwVersion > FACT_CONTENT_VERSION) |
There was a problem hiding this comment.
Suggested change
| header.dwVersion > FACT_CONTENT_VERSION) | |
| header.dwVersion > FACT_CONTENT_VERSION ) |
src/FACT_internal.c
Outdated
| { | ||
| return -2; | ||
| } | ||
|
|
||
| if (!FACT_INTERNAL_SupportedWBContent(header.dwHeaderVersion)) | ||
| if ( header.dwVersion > FACT_CONTENT_VERSION_2_4 && | ||
| !FACT_INTERNAL_SupportedWBContent(header.dwHeaderVersion)) |
There was a problem hiding this comment.
Suggested change
| !FACT_INTERNAL_SupportedWBContent(header.dwHeaderVersion)) | |
| !FACT_INTERNAL_SupportedWBContent(header.dwHeaderVersion) ) |
In xactengine 2.5, the extra field HeaderVersion was added.
alesliehughes
force-pushed
the
older_versions
branch
from
97f0f00
to
1e31d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In xactengine 2.5, the extra field HeaderVersion was added.