Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify strError tests to avoid differencies between platforms #802

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Apr 27, 2019

This PR fixes #763. This PR fixes #803.

I simplified the tests for strError so that we do not need to write complex if-else preprocessor conditions to check the slightly different messages in every platform.

@piponazo piponazo requested review from clanmills and D4N April 27, 2019 12:41
@piponazo piponazo self-assigned this Apr 27, 2019
@D4N
Copy link
Member

D4N commented Apr 27, 2019

Lgtm, but gitlab is unhappy

@piponazo
Copy link
Collaborator Author

Damn it ... gmock is not available in some of the Gitlab distros. I'll work to bring it. I expect to use GMock to mock some classes in the future.

@clanmills
Copy link
Collaborator

You may (or may not) find my notes helpful: #575

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c6d1470). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #802   +/-   ##
=========================================
  Coverage          ?   70.79%           
=========================================
  Files             ?      145           
  Lines             ?    19081           
  Branches          ?        0           
=========================================
  Hits              ?    13509           
  Misses            ?     5572           
  Partials          ?        0
Impacted Files Coverage Δ
unitTests/test_futils.cpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d1470...fa7748a. Read the comment docs.

@D4N
Copy link
Member

D4N commented Apr 28, 2019

I've tried adding gmock in via 38b8ad7, let's see whether that works.

@nehaljwani
Copy link
Collaborator

CI is happy now!

@piponazo
Copy link
Collaborator Author

Now, I only need an approval! 😇

Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll cleanup the commit log, then I'll approve.

@D4N D4N merged commit ce3287a into master Apr 29, 2019
@mergify mergify bot deleted the fix763 branch April 29, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install GMock in the Gitlab jobs missing it False Negatives in Unit Tests
4 participants