-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify strError tests to avoid differencies between platforms #802
Conversation
Lgtm, but gitlab is unhappy |
Damn it ... gmock is not available in some of the Gitlab distros. I'll work to bring it. I expect to use GMock to mock some classes in the future. |
You may (or may not) find my notes helpful: #575 |
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
=========================================
Coverage ? 70.79%
=========================================
Files ? 145
Lines ? 19081
Branches ? 0
=========================================
Hits ? 13509
Misses ? 5572
Partials ? 0
Continue to review full report at Codecov.
|
I've tried adding gmock in via 38b8ad7, let's see whether that works. |
CI is happy now! |
Now, I only need an approval! 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll cleanup the commit log, then I'll approve.
Co-Author: Nehal J Wani <nehaljw.kkd1@gmail.com>
This PR fixes #763. This PR fixes #803.
I simplified the tests for
strError
so that we do not need to write complex if-else preprocessor conditions to check the slightly different messages in every platform.