Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in isoSpeed() #564

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Fix in isoSpeed() #564

merged 2 commits into from
Nov 26, 2018

Conversation

piponazo
Copy link
Collaborator

Fix #561.

I am not very familiar with the code, but It seems that we were using the wrong counter for the idx variable in the isoSpeed() function. The counter variable cnt had a value of 25 while the number of keys is always a number between 1 and 3 (sensKeys->count).

@piponazo piponazo added this to the v0.27 milestone Nov 26, 2018
Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never look at that code. However I think it's a fuzzed file that has a deliberately illegal value that causes an out-of-bouds reference in a static structure. If the POC now passes and the test suite is happy, this is almost certainly a good fix.

Thanks for dealing with this.

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #564 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   62.73%   62.74%   +<.01%     
==========================================
  Files         154      154              
  Lines       20680    20680              
==========================================
+ Hits        12974    12976       +2     
+ Misses       7706     7704       -2
Impacted Files Coverage Δ
src/easyaccess.cpp 97.59% <100%> (+1.2%) ⬆️
src/bigtiffimage.cpp 62.03% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2e0de...923e6d3. Read the comment docs.

@piponazo piponazo merged commit 6e42c1b into Exiv2:master Nov 26, 2018
@piponazo piponazo deleted the fix561 branch November 26, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants