Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -pR option in Release mode #558

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Disable -pR option in Release mode #558

merged 4 commits into from
Nov 22, 2018

Conversation

piponazo
Copy link
Collaborator

This PR fixes #547.

Note that as I discussed in that issue, some tests where using the option -pR and I decided to skip them, in the case of the python tests, or directly remove them (the case of the bash test).

Right now we do not have any CI job compiling and testing the project in Debug mode. This would be a considerable amount of work and it would probably delay the 0.27 release. I think it would be better to add CI jobs to compile and test the project in Debug mode after the release, and in that moment we could add the tests back (in case it is needed). If you agree with this strategy, I will create an issue for not forgetting about this.

@piponazo piponazo added this to the v0.27 milestone Nov 22, 2018
@piponazo piponazo self-assigned this Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #558 into master will decrease coverage by 0.71%.
The diff coverage is 76.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   63.45%   62.73%   -0.72%     
==========================================
  Files         154      154              
  Lines       20661    20680      +19     
==========================================
- Hits        13110    12974     -136     
- Misses       7551     7706     +155
Impacted Files Coverage Δ
src/exiv2.cpp 68.48% <76.74%> (+0.94%) ⬆️
src/jp2image.cpp 27.77% <0%> (-14.04%) ⬇️
src/pngimage.cpp 78.82% <0%> (-12.06%) ⬇️
src/iptc.cpp 73.7% <0%> (-6.9%) ⬇️
src/image.cpp 77.91% <0%> (-6.7%) ⬇️
src/jpgimage.cpp 79.79% <0%> (-2.31%) ⬇️
src/image_int.cpp 36.95% <0%> (-2.18%) ⬇️
src/pngchunk_int.cpp 88.84% <0%> (-1.16%) ⬇️
src/webpimage.cpp 66.48% <0%> (-0.55%) ⬇️
src/basicio.cpp 42.58% <0%> (-0.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee30a8...36a20e3. Read the comment docs.

Copy link
Collaborator

@clanmills clanmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes -pR in the exiv2 command-line program and that's a great step forward.

I was intending to fix this in the library itself by throwing a new error from image->printStructure() and Image::printIFDStructure(). However, this is a "low risk" approach.

@piponazo piponazo merged commit 3f2e0de into Exiv2:master Nov 22, 2018
@piponazo piponazo deleted the fix547 branch November 22, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient verification(cycle) in function Image::printIFDStructure in image.cpp:335
2 participants