Disable -pR option in Release mode #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #547.
Note that as I discussed in that issue, some tests where using the option
-pR
and I decided to skip them, in the case of the python tests, or directly remove them (the case of the bash test).Right now we do not have any CI job compiling and testing the project in Debug mode. This would be a considerable amount of work and it would probably delay the 0.27 release. I think it would be better to add CI jobs to compile and test the project in Debug mode after the release, and in that moment we could add the tests back (in case it is needed). If you agree with this strategy, I will create an issue for not forgetting about this.