optimize toAscii (backport #2693) #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
GCC is able to see that the branch is useless as it can be done at compile time. Produces shorter assembly with both -O2 and -O3. Assign the pointer to the std::string directly and use proper iterators with std::transform. Also produces shorter assembly. Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit 22a4b71)
c == 0 was a dead branch because of the way printable ascii was calculated. Move it up instead. While at it, replace std::transform with std::replace. Easier to read. Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit e1b3dfa)
Merged
kmilos
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct string in lambda to help the compiler optimize the generated code. Also replace transform with normal loop.
This is an automatic backport of pull request #2693 done by Mergify.