Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use if constexpr instead of macros #2686

Merged
merged 1 commit into from
Jul 11, 2023
Merged

use if constexpr instead of macros #2686

merged 1 commit into from
Jul 11, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 10, 2023

No description provided.

@neheb
use if constexpr instead of macros
3aa71a8 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@ghost
Copy link

ghost commented Jul 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb neheb requested a review from kmilos July 10, 2023 20:04
kmilos
kmilos approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit 50648dd into Exiv2:main Jul 11, 2023
105 checks passed
@neheb neheb deleted the comma branch July 11, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @kmilos