github CI: remove msvcrt #2683
Merged
github CI: remove msvcrt #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvcrt support was effectively killed when wstring support was removed. No need to test for it. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 103 103
Lines 22313 22313
Branches 10799 10799
=======================================
Hits 14258 14258
Misses 5830 5830
Partials 2225 2225 |
kmilos
approved these changes
Jul 9, 2023
|
@Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msvcrt support was effectively killed when wstring support was removed. No need to test for it.