Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiv2 v0.28.0 #2602

Merged
merged 1 commit into from
May 8, 2023
Merged

Exiv2 v0.28.0 #2602

merged 1 commit into from
May 8, 2023

Conversation

nehaljwani
Copy link
Collaborator

It is time to cut a release 🙂

xref: #2406

@ghost
Copy link

ghost commented May 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #2602 (cdcfac7) into 0.28.x (c86ae6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.28.x    #2602   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files         103      103           
  Lines       22309    22309           
  Branches    10795    10795           
=======================================
  Hits        14262    14262           
  Misses       5825     5825           
  Partials     2222     2222           

@neheb
Copy link
Collaborator

neheb commented May 8, 2023

I'd also make the necessary changes to the meson.build file.

@neheb
Copy link
Collaborator

neheb commented May 8, 2023

Maybe also undo dd48bb1

Was needed when version was 1.0.0

@nehaljwani
Copy link
Collaborator Author

It is nice to have a soversion, I don't see a good reason to remove it.

@neheb
Copy link
Collaborator

neheb commented May 8, 2023

So the soversion is automatic when version is specified. That commit is an override.

@nehaljwani
Copy link
Collaborator Author

nehaljwani commented May 8, 2023

According to the manual, it seems to default to the project major:

For example, if version is 3.6.0 and soversion is not defined, it is set to 3.

But we have been setting it to the minor version [via the CMake builds] (before 1.0.0), so the override is required.

@nehaljwani nehaljwani merged commit 931a40a into Exiv2:0.28.x May 8, 2023
@kevinbackhouse kevinbackhouse added this to the v0.28.0 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants