-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current master fails with image #2565 #2586
Conversation
I don't know much C++, so forgive me if I'm very wrong, but I don't understand the reasoning behind adding a |
…rying to access outofband offest
Hello @ben,
buf.data(2) : we try to read size-2=0 bytes from the third byte : segmentation fault becaue the size of buffer is 2. |
Codecov Report
@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 63.92% 63.92%
=======================================
Files 103 103
Lines 22374 22311 -63
Branches 10823 10795 -28
=======================================
- Hits 14302 14262 -40
+ Misses 5851 5828 -23
Partials 2221 2221
... and 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…rying to access outofband offest: check all locations
Thanks @mohamedchebbii! Would you be able to add a test with the image from #2565 to prove it works and prevent regressions? |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
…rying to access outofband offest: add test files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
Reading the same image here : #2565 (comment)