Minimal support for parsing DCP files #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2574 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 103 103
Lines 22381 22383 +2
Branches 10823 10823
=======================================
+ Hits 14309 14311 +2
Misses 5851 5851
Partials 2221 2221
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kmilos
changed the title
neheb
approved these changes
Apr 10, 2023
kmilos
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I'm not sure about is whether I should sethasImageTags_tofalse- DCP files only carry metadata tags, no actual image...Edit: as this is a quick/dirty fix along the lines of #1919, perhaps there will be a long term need to separate this into a separate handler (although the overlap here w/ existing TIFF/DNG tags is 100%).