direct initialize some structs

[neheb]

No description provided.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2570 (423774a) into main (0fa22ed) will increase coverage by 0.02%.
The diff coverage is 41.17%.

❗ Current head 423774a differs from pull request most recent head 1403a43. Consider uploading reports for the commit 1403a43 to get more accurate results

@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
+ Coverage   63.90%   63.93%   +0.02%     
==========================================
  Files         103      103              
  Lines       22393    22381      -12     
  Branches    10824    10823       -1     
==========================================
- Hits        14310    14309       -1     
+ Misses       5864     5851      -13     
- Partials     2219     2221       +2     

Impacted Files	Coverage Δ
include/exiv2/bmffimage.hpp	100.00% <ø> (ø)
include/exiv2/error.hpp	54.54% <ø> (ø)
src/basicio.cpp	50.58% <ø> (ø)
src/cr2header_int.hpp	0.00% <ø> (ø)
src/epsimage.cpp	1.93% <0.00%> (+0.05%)	⬆️
src/image_int.hpp	100.00% <ø> (ø)
src/makernote_int.cpp	65.85% <0.00%> (-0.50%)	⬇️
src/nikonmn_int.cpp	61.09% <ø> (ø)
src/sonymn_int.cpp	79.96% <ø> (ø)
src/tiffcomposite_int.hpp	97.27% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[piponazo]

Ey @neheb , in this PR you are mixing 2 different unrelated topics:

• Initialization of structures
• Remove constness from some variable members.

The 1st one I would approve without blinking my eyes. The 2nd one is a bit more controversial. What's your rationale to remove const from those variables? I guess the original authors of those pieces of code gave a lot of though to use const in there.

[neheb]

I can split up into separate PRs.

const removal is done by https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html

[piponazo]

I can split up into separate PRs.

const removal is done by https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html

Sure, If you do that, I will approve quickly the 1st part :)

[neheb]

I can split up into separate PRs.
const removal is done by https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html

Sure, If you do that, I will approve quickly the 1st part :)

Done.