Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove codecvt #2563

Merged
merged 1 commit into from
Mar 27, 2023
Merged

remove codecvt #2563

merged 1 commit into from
Mar 27, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 26, 2023

Deprecated in C++17

@ghost
Copy link

ghost commented Mar 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@neheb
Copy link
Collaborator Author

neheb commented Mar 26, 2023

 Warning: iconv_open: Invalid argument (errno = 22)

hmmmm

@neheb neheb force-pushed the ccvt branch 4 times, most recently from d8a8a93 to 70bec20 Compare March 27, 2023 00:32
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2563 (c78f649) into main (2e33dad) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2563      +/-   ##
==========================================
- Coverage   63.90%   63.90%   -0.01%     
==========================================
  Files         103      103              
  Lines       22394    22393       -1     
  Branches    10825    10824       -1     
==========================================
- Hits        14312    14310       -2     
- Misses       5863     5864       +1     
  Partials     2219     2219              
Impacted Files Coverage Δ
src/helper_functions.cpp 88.63% <100.00%> (-2.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb force-pushed the ccvt branch 4 times, most recently from 776d840 to 508a2b0 Compare March 27, 2023 01:01
Deprecated in C++17

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit 0fa22ed into Exiv2:main Mar 27, 2023
@neheb neheb deleted the ccvt branch March 27, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants