-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::array removals #2559
std::array removals #2559
Conversation
@kmilos should fix CLANG64 compilation. |
From my reading of the code, Exiv2::ExifData::const_iterator evaluates to std::list::const_iterator. It's interesting that only CLANG64 on MSYS2 fails to compile. |
Codecov Report
@@ Coverage Diff @@
## main #2559 +/- ##
=======================================
Coverage 63.90% 63.90%
=======================================
Files 103 103
Lines 22398 22398
Branches 10830 10830
=======================================
Hits 14314 14314
Misses 5863 5863
Partials 2221 2221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yeah, but we're not initializing the array with the return value, but with the function pointer, no? And that's not a literal either, but should be known/constant at compile time? Anyhow, it would good if @1div0 could spare us a minute and try main w/ -DBUILD_SAMPLES=ON on his F38 using Clang 15 as well please? |
Sure, will do in the evening or WE. 2 busy now. |
Yeah it should be. Probably a big with clang-15. |
const_iterator is not constexpr. clang 15 on MSYS2 fails to compile because of this. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's not merge just yet, until @1div0 can give feedback on main as is
OK |
That error seems unrelated. Also, why are you building Jzon.cpp? That was removed from CMake quite a while ago. edit:hmmm I ran that exiv2 command on my local Picture collection. I got
in a specific folder. Can't get a backtrace with gdb for some reason. |
No description provided.