various clang fixes

[neheb]

No description provided.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2556 (8debb0b) into main (8b96ebc) will decrease coverage by 0.77%.
The diff coverage is 70.72%.

@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
- Coverage   64.67%   63.90%   -0.77%     
==========================================
  Files         103      103              
  Lines       22226    22398     +172     
  Branches    10860    10830      -30     
==========================================
- Hits        14374    14314      -60     
- Misses       5614     5863     +249     
+ Partials     2238     2221      -17     

Impacted Files	Coverage Δ
include/exiv2/asfvideo.hpp	66.66% <ø> (ø)
include/exiv2/matroskavideo.hpp	60.00% <ø> (ø)
include/exiv2/metadatum.hpp	78.57% <ø> (ø)
include/exiv2/pgfimage.hpp	100.00% <ø> (ø)
include/exiv2/riffvideo.hpp	100.00% <ø> (ø)
include/exiv2/slice.hpp	91.30% <ø> (ø)
include/exiv2/tags.hpp	0.00% <ø> (ø)
src/crwimage_int.hpp	100.00% <ø> (+6.25%)	⬆️
src/easyaccess.cpp	94.44% <ø> (ø)
src/epsimage.cpp	1.88% <0.00%> (-0.05%)	⬇️
... and 60 more

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[kmilos]

LGTM

[kmilos]

Hm, didn't seem to do it for MSYS2 CLANG64 still:

C:/msys64/home/kmilos/exiv2/samples/easyaccess-test.cpp:15:3: error: constexpr variable 'easyAcces
s' must be initialized by a constant expression
} easyAccess[] = {
  ^              ~
1 error generated.

No idea what's going on... Perhaps it's strict about those function pointers not being constants themselves?

[neheb]

No they're pointers. Using & results in a const pointer unless you const_cast.

Maybe one of those functions is missing for some reason.

[neheb]

According to ChatGPT:

The error you're seeing is caused by the fact that the Exiv2::ExifData::const_iterator type is not a literal type, which means it cannot be used in a constexpr context.