Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enforce, not assert, to avoid crash #2545

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes a second bug found by the same OSS-Fuzz testcase as #2544.

@ghost
Copy link

ghost commented Mar 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #2545 (1333ece) into main (1697417) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   64.59%   63.97%   -0.62%     
==========================================
  Files         103      103              
  Lines       22224    22469     +245     
  Branches    10857    10859       +2     
==========================================
+ Hits        14356    14375      +19     
- Misses       5633     5873     +240     
+ Partials     2235     2221      -14     
Impacted Files Coverage Δ
src/matroskavideo.cpp 4.57% <0.00%> (-0.10%) ⬇️

... and 57 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit a783320 into Exiv2:main Mar 12, 2023
@kevinbackhouse kevinbackhouse deleted the matroska-use-enforce branch March 12, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants