Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz issue : check that block is not corrupted before decoding #2509

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

mohamedchebbii
Copy link
Contributor

@mohamedchebbii mohamedchebbii commented Feb 13, 2023

Fixing the issue faced here : #2450 (comment)
We should throw exception when the size of the block is higher than the size of the file

@ghost
Copy link

ghost commented Feb 13, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #2509 (c555a70) into main (976dcd8) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##             main    #2509   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files         104      104           
  Lines       22256    22259    +3     
  Branches    10863    10864    +1     
=======================================
+ Hits        14394    14397    +3     
  Misses       5619     5619           
  Partials     2243     2243           
Impacted Files Coverage Δ
src/asfvideo.cpp 56.29% <71.42%> (+0.17%) ⬆️
include/exiv2/asfvideo.hpp 66.66% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevinbackhouse kevinbackhouse merged commit b456628 into Exiv2:main Feb 13, 2023
@mohamedchebbii mohamedchebbii deleted the FUZZ_VIDEO branch March 3, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants