Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable video support by default #2506

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Enable video support by default #2506

merged 1 commit into from
Feb 14, 2023

Conversation

benmccann
Copy link
Contributor

The known fuzzing issues in the video code have been fixed. This re-enables video support so that OSS-Fuzz starts fuzzing the video code again.

Ref #2450

@ghost
Copy link

ghost commented Feb 10, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2506 (e0daf5c) into main (aa16a54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2506   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         104      104           
  Lines       22402    22402           
  Branches    10914    10914           
=======================================
  Hits        14444    14444           
  Misses       5710     5710           
  Partials     2248     2248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator

neheb commented Feb 10, 2023

meson build enables by default FWIW. It might be too eary for cmake.

@benmccann
Copy link
Contributor Author

Does that mean OSS-Fuzz is already being run with video support enabled? How long do you think it needs to run before we declare the code safe enough for general release?

@neheb neheb merged commit 6ca75a8 into Exiv2:main Feb 14, 2023
@benmccann benmccann deleted the enable-video branch February 14, 2023 23:53
@1div0
Copy link
Collaborator

1div0 commented Feb 20, 2023

So far it looks very good. Thank you so much. I will put it to the test on my video library as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants