Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2504

Merged
merged 4 commits into from
Feb 10, 2023
Merged

fixes #2504

merged 4 commits into from
Feb 10, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 10, 2023

No description provided.

@ghost
Copy link

ghost commented Feb 10, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Just direct initialize

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Just use upper

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2504 (dee0598) into main (aa16a54) will decrease coverage by 0.02%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
- Coverage   64.47%   64.46%   -0.02%     
==========================================
  Files         104      104              
  Lines       22402    22389      -13     
  Branches    10914    10911       -3     
==========================================
- Hits        14444    14432      -12     
  Misses       5710     5710              
+ Partials     2248     2247       -1     
Impacted Files Coverage Δ
src/riffvideo.cpp 59.56% <40.00%> (-0.53%) ⬇️
src/image.cpp 71.09% <78.57%> (-0.26%) ⬇️
include/exiv2/riffvideo.hpp 100.00% <100.00%> (ø)
src/makernote_int.cpp 66.79% <100.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit 4bdee6f into Exiv2:main Feb 10, 2023
@neheb neheb deleted the r branch February 10, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants