Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contains function #2500

Merged
merged 2 commits into from
Feb 14, 2023
Merged

add contains function #2500

merged 2 commits into from
Feb 14, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 8, 2023

Signed-off-by: Rosen Penev rosenp@gmail.com

@ghost
Copy link

ghost commented Feb 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #2500 (d66e054) into main (52ab999) will increase coverage by 0.00%.
The diff coverage is 62.96%.

❗ Current head d66e054 differs from pull request most recent head b577f9e. Consider uploading reports for the commit b577f9e to get more accurate results

@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   64.66%   64.67%           
=======================================
  Files         103      104    +1     
  Lines       22247    22256    +9     
  Branches    10858    10863    +5     
=======================================
+ Hits        14386    14394    +8     
+ Misses       5620     5619    -1     
- Partials     2241     2243    +2     
Impacted Files Coverage Δ
app/exiv2.cpp 63.32% <0.00%> (ø)
src/canonmn_int.cpp 73.41% <0.00%> (-0.08%) ⬇️
src/makernote_int.cpp 66.79% <0.00%> (ø)
src/olympusmn_int.cpp 44.68% <0.00%> (ø)
src/bmffimage.cpp 73.15% <50.00%> (-0.06%) ⬇️
src/xmpsidecar.cpp 67.28% <66.66%> (ø)
src/easyaccess.cpp 94.44% <100.00%> (ø)
src/nikonmn_int.cpp 63.11% <100.00%> (ø)
src/sonymn_int.cpp 80.48% <100.00%> (ø)
src/utils.hpp 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator Author

neheb commented Feb 8, 2023

@neheb
Copy link
Collaborator Author

neheb commented Feb 10, 2023

ping @kmilos

src/canonmn_int.cpp Show resolved Hide resolved
src/value.cpp Outdated Show resolved Hide resolved
src/value.cpp Outdated Show resolved Hide resolved
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb neheb merged commit 9f21b78 into Exiv2:main Feb 14, 2023
@neheb neheb deleted the c2 branch February 14, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants