Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small clang-tidy fixes #2493

Merged
merged 2 commits into from
Feb 6, 2023
Merged

small clang-tidy fixes #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60fcb9d
move initialization up
neheb Feb 1, 2023
ed30504
default initializations
neheb Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/basicio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,8 +911,7 @@ void XPathIo::ReadDataUri(const std::string& path) {
}

#else
XPathIo::XPathIo(const std::string& orgPath) : FileIo(XPathIo::writeDataToFile(orgPath)) {
tempFilePath_ = path();
XPathIo::XPathIo(const std::string& orgPath) : FileIo(XPathIo::writeDataToFile(orgPath)), tempFilePath_(path()) {
}

XPathIo::~XPathIo() {
Expand Down
3 changes: 0 additions & 3 deletions src/tiffcomposite_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ TiffBinaryArray::TiffBinaryArray(uint16_t tag, IfdId group, const ArraySet* arra
}

TiffBinaryElement::TiffBinaryElement(uint16_t tag, IfdId group) : TiffEntryBase(tag, group) {
elDef_.idx_ = 0;
elDef_.tiffType_ = ttUndefined;
elDef_.count_ = 0;
}

TiffDirectory::~TiffDirectory() {
Expand Down
2 changes: 1 addition & 1 deletion src/tiffcomposite_int.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,7 @@ class TiffBinaryElement : public TiffEntryBase {

private:
// DATA
ArrayDef elDef_; //!< The array element definition
ArrayDef elDef_{0, ttUndefined, 0}; //!< The array element definition
ByteOrder elByteOrder_{invalidByteOrder}; //!< Byte order to read/write the element

}; // class TiffBinaryElement
Expand Down
5 changes: 2 additions & 3 deletions src/tiffvisitor_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,10 +449,9 @@ TiffEncoder::TiffEncoder(ExifData exifData, const IptcData& iptcData, const XmpD
pRoot_(pRoot),
isNewImage_(isNewImage),
pPrimaryGroups_(pPrimaryGroups),
byteOrder_(pHeader->byteOrder()),
origByteOrder_(byteOrder_),
findEncoderFct_(findEncoderFct) {
byteOrder_ = pHeader->byteOrder();
origByteOrder_ = byteOrder_;

encodeIptc();
encodeXmp();

Expand Down