find changes #2462
find changes #2462
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2462 +/- ##
=======================================
Coverage 62.08% 62.09%
=======================================
Files 121 121
Lines 22830 22831 +1
Branches 11212 11212
=======================================
+ Hits 14175 14176 +1
Misses 6448 6448
Partials 2207 2207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neheb
force-pushed
the
2
branch
2 times, most recently
from
82ad0c0
to
81d7de1
Compare
|
hmmm should the find() template be public API? |
neheb
force-pushed
the
2
branch
2 times, most recently
from
73a17b3
to
c9a79e2
Compare
| @@ -317,7 +317,7 @@ void readWriteEpsMetadata(BasicIo& io, std::string& xmpPacket, NativePreviewList | |||
| #ifdef DEBUG | |||
| EXV_DEBUG << "readWriteEpsMetadata: First line: " << firstLine << "\n"; | |||
| #endif | |||
| bool matched = std::find(epsFirstLine.begin(), epsFirstLine.end(), firstLine) != epsFirstLine.end(); | |||
| auto matched = Exiv2::find(epsFirstLine, firstLine); | |||
There was a problem hiding this comment.
[discussion] auto here is taking the value of T *. Even though it is not needed, I normally find more readable to use auto * to declare the intention of using pointers. What do you think about this?
There was a problem hiding this comment.
I don't like auto* mostly because of const. Eg.
auto = const char*
auto* = char*
const auto = const char* const
const auto* = const char*
Regular auto makes more sense IMO.
mergify
bot
dismissed
piponazo’s stale review
Pull request has been modified.
std::find in C++20 can use ranges, which is equivalent here. Less error prone. Namespace is properly to avoid any conflicts with std::find or others Signed-off-by: Rosen Penev <rosenp@gmail.com>
The latter is simpler. Signed-off-by: Rosen Penev <rosenp@gmail.com>
👇 Click on the image for a new way to code review
Legend |
|
ping @kmilos |
Not sure if better.