Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual fixes #2455

Merged
merged 5 commits into from
Jan 6, 2023
Merged

manual fixes #2455

merged 5 commits into from
Jan 6, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jan 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #2455 (89f904e) into main (a84df11) will decrease coverage by 0.01%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   62.10%   62.08%   -0.02%     
==========================================
  Files         121      121              
  Lines       22833    22830       -3     
  Branches    11212    11212              
==========================================
- Hits        14181    14175       -6     
- Misses       6445     6448       +3     
  Partials     2207     2207              
Impacted Files Coverage Δ
include/exiv2/image.hpp 100.00% <ø> (ø)
src/asfvideo.cpp 4.01% <0.00%> (ø)
src/bmffimage.cpp 73.21% <0.00%> (ø)
src/epsimage.cpp 1.92% <0.00%> (ø)
src/futils.cpp 75.29% <ø> (ø)
src/jp2image.cpp 71.30% <0.00%> (ø)
src/jpgimage.cpp 68.69% <0.00%> (ø)
src/matroskavideo.cpp 4.08% <0.00%> (ø)
src/pgfimage.cpp 44.23% <0.00%> (ø)
src/pngimage.cpp 62.01% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented Jan 4, 2023

undefined reference to `INIReader::INIReader(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)'

Fallout from recently commited external inireader.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it is related to the changes you did, but the fuzzer job failed. Can you actually retrigger those CI jobs? Otherwise I can do it for you.

src/futils.cpp Outdated Show resolved Hide resolved
Signed-off-by: Rosen Penev <rosenp@gmail.com>
@neheb
Copy link
Collaborator Author

neheb commented Jan 6, 2023

@piponazo as I mentioned earlier, CIFuzz error is related to #2443 , not this PR.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@neheb neheb merged commit 842ef05 into Exiv2:main Jan 6, 2023
@neheb neheb deleted the 3 branch January 6, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants