Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy on Windows #2452

Merged
merged 3 commits into from
Jan 4, 2023
Merged

clang-tidy on Windows #2452

merged 3 commits into from
Jan 4, 2023

Commits on Jan 4, 2023

  1. clang-tidy on Windows 

    Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5486cb4 View commit details
    Browse the repository at this point in the history

  2. use some if constexpr 

    MSVC suggests this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    86a73b9 View commit details
    Browse the repository at this point in the history

  3. fix __cplusplus check for MSVC 

    Because of an MSVC bug, __cplusplus is always 199711L. Use _MSVC_LANG
which gets set properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6a3984b View commit details
    Browse the repository at this point in the history