Prefer writing PNG eXIf chunk #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #2440 +/- ##
==========================================
- Coverage 65.43% 65.43% -0.01%
==========================================
Files 118 118
Lines 21661 21661
Branches 10465 10467 +2
==========================================
- Hits 14174 14173 -1
Misses 5296 5296
- Partials 2191 2192 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kevinbackhouse
approved these changes
Dec 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2250
We still support reading the (unregistered) legacy text chunks, but always write out the eXIf chunk added to the PNG spec (as Exiftool does).