Rename resp. remove duplicate exif keys #2434
Conversation
Duplicate key names with different tag are renamed Following most of the existing entries, the key with higher tag number is renamed to ...2. Exceptions: Canon.CustomFunctions,Olympus.ImageHeight,Olympus.ImageWidth In the available images samples only the key with higher tag number is used, so changing the other has less impact on test data and also on users. Canon.WhiteBalanceTable with tag 0x00a4 was listed twice, once with description "SharpnessTable". The entry with the deviating description is deleted.
…rtwg/exiv2 into rename-duplicate-exif-keys
…rtwg/exiv2 into rename-duplicate-exif-keys
Codecov Report
@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
+ Coverage 65.43% 65.48% +0.05%
==========================================
Files 118 118
Lines 21661 21661
Branches 10467 10467
==========================================
+ Hits 14173 14184 +11
+ Misses 5296 5280 -16
- Partials 2192 2197 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
No idea why the CI fails, and if it's safe to merge... Maybe rebase to include the CI switch to Ubuntu 22.04? |
Yes, the CI issue was fixed already. Please rebase your branch in top of |
mergify
bot
dismissed
kevinbackhouse’s stale review
Pull request has been modified.
|
I updated my branch to reflect latest changes in main. Still one failed check: |
|
I've restarted the job, let's see... Btw, for future reference, please rebase the PR branch on top of main, not merge main into it. |
Duplicate key names with different tag are renamed. Following most of the existing entries, the key with higher tag number is renamed to ...2.
Exception: Canon.CustomFunctions, Olympus.ImageHeight, Olympus.ImageWidth. In the available images samples only the key with higher tag number is used, so changing the other has less impact on test data and also on users.
Canon.WhiteBalanceTable with tag 0x00a4 was listed twice, once with description "SharpnessTable". The entry with the deviating description is deleted.