Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1748 Video Support in V1.0: part 3/3 : support Asfvideo #2416

Merged
merged 8 commits into from
Dec 31, 2022

Conversation

mohamedchebbii
Copy link
Contributor

./bin/exiv2 -p x  ~/Downloads/sample/sample_1280x720_surfing_with_audio.asf 
Xmp.video.FileSize                           XmpText     7  28.3989
Xmp.video.FileName                           XmpText    95  /home/mohamed.chebbi/Downloads/sample/sample_1280x720_surfing_with_audio.asf
Xmp.video.MimeType                           XmpText     9  video/asf
Xmp.video.FileID                             XmpText    36  00000000-0000-0000-0000-000000000000
Xmp.video.FileLength                         XmpText     8  29778366
Xmp.video.CreationDate                       XmpText    18  116444736000000000
Xmp.video.DataPackets                        XmpText     4  9305
Xmp.video.Duration                           XmpText     6  186226
Xmp.video.SendDuration                       XmpText     6  183126
Xmp.video.Preroll                            XmpText     4  3100
Xmp.video.MaxBitRate                         XmpText    14  13194139861312
Xmp.video.TrackLang                          XmpSeq      1  en
Xmp.video.Metadata                           XmpSeq      4  AspectRatioX, 1, AspectRatioY, 1
Xmp.video.ExtendedContentDescription         XmpSeq      8  major_brand, mp42, minor_version, 512, compatible_brands, isomiso2avc1mp41, WM/EncodingSettings, Lavf58.45.100
Xmp.video.TimeOffset                         XmpText     1  0
Xmp.video.Width                              XmpText     4  1280
Xmp.video.Height                             XmpText     3  720
Xmp.audio.TimeOffset                         XmpText     1  0
Xmp.audio.ChannelType                        XmpText     1  2
Xmp.audio.SampleRate                         XmpText     5  48000
Xmp.video.Codec                              XmpText    10  msmpeg4v3
Xmp.video.CodecDescription                   XmpText     0  
Xmp.audio.Compressor                         XmpText    23  Windows Media Audio V8
Xmp.audio.CodecDescription                   XmpText     0  
Xmp.video.AspectRatio                        XmpText     4  16:9

@lgtm-com
Copy link

lgtm-com bot commented Nov 7, 2022

This pull request introduces 3 alerts when merging 009aa70 into faa7cc3 - view on LGTM.com

new alerts:

  • 3 for Comparison result is always the same

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2416 (ad72e1e) into main (d755fc1) will decrease coverage by 0.95%.
The diff coverage is 4.05%.

@@            Coverage Diff             @@
##             main    #2416      +/-   ##
==========================================
- Coverage   63.05%   62.09%   -0.96%     
==========================================
  Files         121      122       +1     
  Lines       22555    22930     +375     
  Branches    10955    11241     +286     
==========================================
+ Hits        14221    14238      +17     
- Misses       6123     6475     +352     
- Partials     2211     2217       +6     
Impacted Files Coverage Δ
src/helper_functions.cpp 12.50% <0.00%> (-47.50%) ⬇️
src/image.cpp 71.51% <ø> (ø)
src/asfvideo.cpp 4.27% <4.27%> (ø)
src/quicktimevideo.cpp 59.11% <0.00%> (-0.12%) ⬇️
src/sonymn_int.cpp 80.48% <0.00%> (ø)
src/matroskavideo.cpp 4.08% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/asfvideo.cpp Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
src/asfvideo.cpp Outdated Show resolved Hide resolved
@piponazo
Copy link
Collaborator

Thanks for your work on the video support! ❤️

@piponazo piponazo merged commit 7fac35e into Exiv2:main Dec 31, 2022
@mohamedchebbii mohamedchebbii deleted the asfvideo branch December 31, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants