Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1748 Video Support in V1.0: part 2/3 : support Riffvideo #2415

Merged
merged 7 commits into from
Dec 31, 2022

Conversation

mohamedchebbii
Copy link
Contributor

./bin/exiv2 -p x  ~/Downloads/file_example_AVI_480_750kB.avi
Xmp.video.FileSize                           XmpText     8  0.708082
Xmp.video.FileName                           XmpText    80  /home/mohamed.chebbi/Downloads/file_example_AVI_480_750kB.avi
Xmp.video.MimeType                           XmpText    10  video/riff
Xmp.video.Container                          XmpText     4  RIFF
Xmp.video.FileType                           XmpText     4  AVI 
Xmp.video.MicroSecPerFrame                   XmpText     5  33333
Xmp.video.MaxDataRate                        XmpText     7  17.0449
Xmp.video.FrameCount                         XmpText     3  901
Xmp.video.StreamCount                        XmpText     1  2
Xmp.video.Width                              XmpText     3  480
Xmp.video.Height                             XmpText     3  270
Xmp.video.AspectRatio                        XmpText     4  16:9
Xmp.video.FileDataRate                       XmpText    11  2.35768e-05
Xmp.video.Duration                           XmpText     5  30033
Xmp.video.Codec                              XmpText     4  H264
Xmp.video.FrameRate                          XmpText     2  30
Xmp.video.VideoQuality                       XmpText    10  4294967295
Xmp.video.VideoSampleSize                    XmpText     1  0
Xmp.video.Planes                             XmpText     1  1
Xmp.video.PixelDepth                         XmpText     2  24
Xmp.video.Compressor                         XmpText     4  H264
Xmp.video.ImageLength                        XmpText     6  388800
Xmp.video.PixelPerMeterX                     XmpText     1  0
Xmp.video.PixelPerMeterY                     XmpText     1  0
Xmp.video.NumOfColours                       XmpText    11  Unspecified
Xmp.video.NumOfImpColours                    XmpText     3  All
Xmp.audio.Codec                              XmpText     1  
Xmp.audio.SampleRate                         XmpText     5  48000
Xmp.audio.SampleCount                        XmpText     4  1435
Xmp.audio.Compressor                         XmpText     3  AAC
Xmp.audio.ChannelType                        XmpText     6  Stereo
Xmp.audio.SampleType                         XmpText     5  17454
Xmp.audio.BitsPerSample                      XmpText     2  16
Xmp.video.Junk                               XmpText     0  
Xmp.video.Software                           XmpText    13  Lavf57.19.100

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2415 (69ae9bf) into main (1280f3b) will decrease coverage by 1.54%.
The diff coverage is 2.84%.

@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
- Coverage   64.59%   63.05%   -1.55%     
==========================================
  Files         120      121       +1     
  Lines       21992    22555     +563     
  Branches    10597    10955     +358     
==========================================
+ Hits        14205    14221      +16     
- Misses       5584     6123     +539     
- Partials     2203     2211       +8     
Impacted Files Coverage Δ
src/image.cpp 71.51% <ø> (ø)
src/riffvideo.cpp 2.84% <2.84%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piponazo
Copy link
Collaborator

Ey @mohamedchebbii . I already merged the 1st PR. Please rebase your branch in top of the latest main to fix the conflicts.

exiv2.md Outdated Show resolved Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@mohamedchebbii
Copy link
Contributor Author

Hello @piponazo ,
I rebased on last vesion of main.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found some minor things that could be improved. Let me know if you are willing to take actions about those suggestions, or otherwise we can also merge it as it is, and I can take care later about those minor things.

src/riffvideo.cpp Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
src/riffvideo.cpp Outdated Show resolved Hide resolved
@piponazo piponazo self-requested a review December 31, 2022 09:44
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the suggestions 🗡️

@piponazo piponazo merged commit d755fc1 into Exiv2:main Dec 31, 2022
@mohamedchebbii mohamedchebbii deleted the riffvideo branch December 31, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants