-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1748 Video Support in V1.0: part 2/3 : support Riffvideo #2415
Conversation
mohamedchebbii
commented
Nov 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #2415 +/- ##
==========================================
- Coverage 64.59% 63.05% -1.55%
==========================================
Files 120 121 +1
Lines 21992 22555 +563
Branches 10597 10955 +358
==========================================
+ Hits 14205 14221 +16
- Misses 5584 6123 +539
- Partials 2203 2211 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ey @mohamedchebbii . I already merged the 1st PR. Please rebase your branch in top of the latest |
5485c10
to
1d8e204
Compare
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Hello @piponazo , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found some minor things that could be improved. Let me know if you are willing to take actions about those suggestions, or otherwise we can also merge it as it is, and I can take care later about those minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the suggestions 🗡️