Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace find/rfind with startsWith #2396

Merged
merged 1 commit into from
Oct 28, 2022
Merged

replace find/rfind with startsWith #2396

merged 1 commit into from
Oct 28, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Oct 27, 2022

Signed-off-by: Rosen Penev rosenp@gmail.com

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #2396 (2641ed6) into main (761acaf) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #2396   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files         119      119           
  Lines       21136    21136           
  Branches    10428    10428           
=======================================
  Hits        13587    13587           
  Misses       5400     5400           
  Partials     2149     2149           
Impacted Files Coverage Δ
src/pentaxmn_int.cpp 71.49% <0.00%> (ø)
src/futils.cpp 74.69% <100.00%> (ø)
src/jpgimage.cpp 68.00% <100.00%> (ø)
src/sonymn_int.cpp 77.52% <100.00%> (ø)
src/xmp.cpp 76.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator Author

neheb commented Oct 27, 2022

CI seems bugged.

@kevinbackhouse
Copy link
Collaborator

CI seems bugged.

I have the same problem in #2395. Comparing this failed build with one that passed recently:

Pass: https://github.com/Exiv2/exiv2/actions/runs/3311978134/jobs/5468094112
Fail: https://github.com/Exiv2/exiv2/actions/runs/3340603185/jobs/5530898781

Looks like the difference is that Chocolatey got upgraded from v1.1.0 to v1.2.0

@neheb neheb merged commit 28d1880 into Exiv2:main Oct 28, 2022
@neheb neheb deleted the 2 branch October 28, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants