Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exif start can be at any byte in payload, not word aligned #2382

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 19, 2022

Cherry-picked from #2381

@kmilos kmilos added this to the v0.27.6 milestone Oct 19, 2022
@kmilos kmilos added bug imageHandler Anything related to specific ImageHandlers labels Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #2382 (cd1f315) into 0.27-maintenance (4f1d091) will not change coverage.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           0.27-maintenance    #2382   +/-   ##
=================================================
  Coverage             58.89%   58.89%           
=================================================
  Files                   149      149           
  Lines                 23203    23203           
  Branches              12711    12711           
=================================================
  Hits                  13666    13666           
  Misses                 6700     6700           
  Partials               2837     2837           
Impacted Files Coverage Δ
src/bmffimage.cpp 76.58% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1div0
Copy link
Collaborator

1div0 commented Oct 19, 2022

Good 1!

Copy link
Collaborator

@1div0 1div0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch.

Hvala @kmilos

@kmilos
Copy link
Collaborator Author

kmilos commented Oct 19, 2022

Thanks, merging.

@kmilos kmilos merged commit cbf549b into 0.27-maintenance Oct 19, 2022
@kmilos kmilos deleted the 027_fix_bmff_exif_offset branch October 19, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug imageHandler Anything related to specific ImageHandlers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants