Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cland-tidy: simplify booleans #2369

Merged
merged 1 commit into from
Sep 27, 2022
Merged

cland-tidy: simplify booleans #2369

merged 1 commit into from
Sep 27, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Sep 25, 2022

Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev rosenp@gmail.com

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #2369 (b0bbe6a) into main (84f566b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files         119      119           
  Lines       20597    20597           
  Branches    10208    10208           
=======================================
  Hits        13076    13076           
  Misses       5392     5392           
  Partials     2129     2129           
Impacted Files Coverage Δ
app/exiv2.cpp 62.54% <0.00%> (ø)
src/convert.cpp 51.40% <0.00%> (ø)
src/crwimage.cpp 70.51% <0.00%> (ø)
src/epsimage.cpp 1.76% <0.00%> (ø)
src/makernote_int.cpp 64.62% <0.00%> (ø)
src/olympusmn_int.cpp 40.79% <0.00%> (ø)
src/preview.cpp 46.63% <0.00%> (ø)
src/tags_int.cpp 77.90% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit d856ca7 into Exiv2:main Sep 27, 2022
@neheb neheb deleted the 2 branch September 27, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants