Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getULong to read unsigned numbers #2363

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

kevinbackhouse
Copy link
Collaborator

getLong returns a signed number. It's better to use getULong when reading an unsigned value.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #2363 (7908f0b) into main (250586e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2363   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files         119      119           
  Lines       20624    20624           
  Branches    10233    10233           
=======================================
  Hits        13100    13100           
  Misses       5395     5395           
  Partials     2129     2129           
Impacted Files Coverage Δ
src/bmffimage.cpp 76.81% <100.00%> (ø)
src/bmpimage.cpp 90.00% <100.00%> (ø)
src/jp2image.cpp 70.35% <100.00%> (ø)
src/tiffvisitor_int.cpp 79.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit 56249bb into Exiv2:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants