Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer overflow in QuickTimeVideo::tagDecoder #2346

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #2345

@kevinbackhouse kevinbackhouse added bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/ labels Sep 5, 2022
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #2346 (344764a) into main (175e609) will decrease coverage by 0.00%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   63.38%   63.38%   -0.01%     
==========================================
  Files         119      119              
  Lines       20621    20631      +10     
  Branches    10231    10243      +12     
==========================================
+ Hits        13071    13077       +6     
- Misses       5420     5424       +4     
  Partials     2130     2130              
Impacted Files Coverage Δ
src/quicktimevideo.cpp 57.04% <47.36%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbackhouse kevinbackhouse merged commit 640b0fb into Exiv2:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of bounds write in QuickTimeVideo::tagDecoder
2 participants