Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more MIME type mappings for TIFF-based raws #2333

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Aug 19, 2022

Now matches known raw file compression tag values in

exiv2/src/tags_int.cpp

Lines 242 to 277 in fa94372

//! Compression, tag 0x0103
extern const TagDetails exifCompression[] = {
{ 1, N_("Uncompressed") },
{ 2, N_("CCITT RLE") },
{ 3, N_("T4/Group 3 Fax") },
{ 4, N_("T6/Group 4 Fax") },
{ 5, N_("LZW") },
{ 6, N_("JPEG (old-style)") },
{ 7, N_("JPEG") },
{ 8, N_("Adobe Deflate") },
{ 9, N_("JBIG B&W") },
{ 10, N_("JBIG Color") },
{ 32766, N_("Next 2-bits RLE") },
{ 32767, N_("Sony ARW Compressed") },
{ 32769, N_("Epson ERF Compressed") },
{ 32770, N_("Samsung SRW Compressed") },
{ 32771, N_("CCITT RLE 1-word") },
{ 32773, N_("PackBits (Macintosh RLE)") },
{ 32809, N_("Thunderscan RLE") },
{ 32895, N_("IT8 CT Padding") },
{ 32896, N_("IT8 Linework RLE") },
{ 32897, N_("IT8 Monochrome Picture") },
{ 32898, N_("IT8 Binary Lineart") },
{ 32908, N_("Pixar Film (10-bits LZW)") },
{ 32909, N_("Pixar Log (11-bits ZIP)") },
{ 32946, N_("Pixar Deflate") },
{ 32947, N_("Kodak DCS Encoding") },
{ 34661, N_("ISO JBIG") },
{ 34676, N_("SGI Log Luminance RLE") },
{ 34677, N_("SGI Log 24-bits packed") },
{ 34712, N_("Leadtools JPEG 2000") },
{ 34713, N_("Nikon NEF Compressed") },
{ 34892, N_("JPEG (lossy)") }, // DNG 1.4
{ 65000, N_("Kodak DCR Compressed") },
{ 65535, N_("Pentax PEF Compressed") }
};

@neheb Please also include in your recent #2332 for main.

Edit: fixes #2260

@kmilos kmilos added the enhancement feature / functionality enhancements label Aug 19, 2022
@kmilos kmilos requested a review from neheb August 19, 2022 10:41
@kmilos kmilos added this to the v0.27.6 milestone Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #2333 (f44bfcf) into 0.27-maintenance (fa94372) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           0.27-maintenance    #2333   +/-   ##
=================================================
  Coverage             58.89%   58.89%           
=================================================
  Files                   149      149           
  Lines                 23203    23203           
  Branches              12711    12711           
=================================================
  Hits                  13666    13666           
  Misses                 6700     6700           
  Partials               2837     2837           
Impacted Files Coverage Δ
src/tiffimage.cpp 71.31% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator

neheb commented Aug 19, 2022

added

@neheb
Copy link
Collaborator

neheb commented Aug 19, 2022

This fixes #2260

@kmilos
Copy link
Collaborator Author

kmilos commented Aug 19, 2022

Well spotted, thanks!

@neheb neheb merged commit 34c8b2b into 0.27-maintenance Aug 21, 2022
@neheb neheb deleted the mime_types_raw branch August 21, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants