Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nikon3.WhiteBalanceBias2 (backport #2311) #2315

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Aug 8, 2022

No description provided.

@piponazo
Copy link
Collaborator

piponazo commented Aug 8, 2022

Failures seem to be due to conan. Would you main to port the changes done at #2314 to this PR ?

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2315 (4251ff3) into 0.27-maintenance (aadb126) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           0.27-maintenance    #2315   +/-   ##
=================================================
  Coverage             58.89%   58.89%           
=================================================
  Files                   149      149           
  Lines                 23203    23203           
  Branches              12711    12711           
=================================================
  Hits                  13666    13666           
  Misses                 6700     6700           
  Partials               2837     2837           
Impacted Files Coverage Δ
src/nikonmn_int.cpp 44.80% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmilos
Copy link
Collaborator Author

kmilos commented Aug 8, 2022

Failures seem to be due to conan.

Yet again :/ Remind me please, why do we have to keep the conan version specified explicitly, can't we just let it use the latest one?

@kmilos kmilos merged commit 232d423 into 0.27-maintenance Aug 9, 2022
@kmilos kmilos deleted the nikon_wb_027 branch August 9, 2022 05:26
@kmilos kmilos added makerNote Anything related to one of the various supported MakerNote formats enhancement feature / functionality enhancements labels Aug 10, 2022
@kmilos kmilos added this to the v0.27.6 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements makerNote Anything related to one of the various supported MakerNote formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants