Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert std::function back to function pointers #2313

Merged
merged 1 commit into from
Aug 9, 2022
Merged

revert std::function back to function pointers #2313

merged 1 commit into from
Aug 9, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 7, 2022

The former has too much overhead. No point in it.

Signed-off-by: Rosen Penev rosenp@gmail.com

@neheb
Copy link
Collaborator Author

neheb commented Aug 7, 2022

seems conan has issues.

@piponazo
Copy link
Collaborator

piponazo commented Aug 8, 2022

@neheb You need to rebase your branch in top of main to avoid the CI failures

The former has too much overhead. No point in it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #2313 (bb6a6ae) into main (2c5e1d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2313      +/-   ##
==========================================
- Coverage   63.48%   63.47%   -0.01%     
==========================================
  Files         118      118              
  Lines       19601    19599       -2     
  Branches     9576     9574       -2     
==========================================
- Hits        12443    12441       -2     
  Misses       5091     5091              
  Partials     2067     2067              
Impacted Files Coverage Δ
app/actions.hpp 100.00% <ø> (ø)
include/exiv2/xmp_exiv2.hpp 89.47% <ø> (ø)
src/convert.cpp 51.40% <ø> (ø)
src/makernote_int.hpp 92.30% <ø> (ø)
src/tiffimage_int.hpp 80.00% <ø> (ø)
app/actions.cpp 64.97% <100.00%> (ø)
src/crwimage_int.hpp 92.85% <100.00%> (-0.17%) ⬇️
src/tiffimage_int.cpp 79.82% <100.00%> (ø)
src/tiffvisitor_int.cpp 79.38% <100.00%> (ø)
src/xmp.cpp 76.54% <100.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit fc84040 into Exiv2:main Aug 9, 2022
@neheb neheb deleted the 4 branch August 9, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants