misc cleanups #2309
Merged
misc cleanups #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
No need. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
These were not const. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
+ Coverage 63.44% 63.48% +0.03%
==========================================
Files 118 118
Lines 19643 19601 -42
Branches 9608 9576 -32
==========================================
- Hits 12462 12443 -19
+ Misses 5112 5091 -21
+ Partials 2069 2067 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Set original file permissions | ||
| if (::chmod(pf, origStMode) == -1) { | ||
| // Set original file permissions | ||
| if (statOk && origStMode != buf2.st_mode && ::chmod(pf, origStMode) == -1) { |
Check failure
Code scanning / CodeQL
Time-of-check time-of-use filesystem race condition
Signed-off-by: Rosen Penev <rosenp@gmail.com>
fs::path is convertable to a string. Signed-off-by: Rosen Penev <rosenp@gmail.com>
I've seen this before. Transient error. |
piponazo
approved these changes
Aug 5, 2022
If this is a flaky test, I would vote to comment it out an create a ticket to investigate what's happening there. In that way it will not create confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.