strcmp to == conversions #2301
Merged
strcmp to == conversions #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the same thing. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2301 +/- ##
=======================================
Coverage 63.53% 63.54%
=======================================
Files 118 118
Lines 19595 19595
Branches 9576 9576
=======================================
+ Hits 12450 12451 +1
+ Misses 5079 5078 -1
Partials 2066 2066
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -24,8 +24,8 @@ uint32_t fillGap(Exiv2::Internal::IoWrapper& ioWrapper, uint32_t curr, uint32_t | |||
| // class member definitions | |||
| namespace Exiv2::Internal { | |||
| bool TiffMappingInfo::operator==(const TiffMappingInfo::Key& key) const { | |||
| return (0 == strcmp("*", make_) || 0 == strncmp(make_, key.m_.c_str(), strlen(make_))) && | |||
There was a problem hiding this comment.
This one is checking that make_ is a prefix of key.m_, so it can't be converted to ==.
There was a problem hiding this comment.
@neheb: I accidentally clicked "start a review" before, so this comment was left in a pending state.
There was a problem hiding this comment.
I've created #2307 to use startsWith here.
kevinbackhouse
added a commit
to kevinbackhouse/exiv2
that referenced
this pull request
Aug 4, 2022
Merged
neheb
pushed a commit
that referenced
this pull request
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the same thing.
Signed-off-by: Rosen Penev rosenp@gmail.com